Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload

From: Lee Jones
Date: Mon Oct 24 2016 - 05:08:13 EST


On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
> alias: of:N*T*Cmailbox-testC*
> alias: of:N*T*Cmailbox-test
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> ---
>
> drivers/mailbox/mailbox-test.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

> diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
> index 9ca96e9db6bf..deb9c61aebb4 100644
> --- a/drivers/mailbox/mailbox-test.c
> +++ b/drivers/mailbox/mailbox-test.c
> @@ -357,6 +357,7 @@ static const struct of_device_id mbox_test_match[] = {
> { .compatible = "mailbox-test" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, mbox_test_match);
>
> static struct platform_driver mbox_test_driver = {
> .driver = {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog