Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in raid5_status()

From: SF Markus Elfring
Date: Thu Oct 06 2016 - 13:10:11 EST


>> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> []
>> @@ -7044,7 +7044,7 @@ static void raid5_status(struct seq_file *seq, struct mddev *mddev)
>> rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_");
>> }
>> rcu_read_unlock();
>> - seq_printf (seq, "]");
>> + seq_puts(seq, "]");
>
> seq_putc

Thanks for your update suggestion.

How do you think about the possibility that the script "checkpatch.pl" can also point
such a source code transformation out directly?
Would an additional check for the length of the passed string be useful in similar
use cases?

Regards,
Markus