Re: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro

From: Punit Agrawal
Date: Mon Oct 03 2016 - 07:05:30 EST


Will Deacon <will.deacon@xxxxxxx> writes:

> On Fri, Sep 23, 2016 at 05:07:10PM +0100, Will Deacon wrote:
>> On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote:
>> > From: Mark Rutland <mark.rutland@xxxxxxx>
>> >
>> > As with dsb() and isb(), add a __tlbi() helper so that we can avoid
>> > distracting asm boilerplate every time we want a TLBI. As some TLBI
>> > operations take an argument while others do not, some pre-processor is
>> > used to handle these two cases with different assembly blocks.
>> >
>> > The existing tlbflush.h code is moved over to use the helper.
>> >
>> > Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
>> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
>> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
>> > [ rename helper to __tlbi, update comment and commit log ]
>> > Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx>
>> > Reviewed-by: Will Deacon <will.deacon@xxxxxxx>
>> > ---
>> > arch/arm64/include/asm/tlbflush.h | 34 ++++++++++++++++++++++++++--------
>> > 1 file changed, 26 insertions(+), 8 deletions(-)
>>
>> Given that this series seems to have stalled, I'm inclined to pick this
>> patch (and only this patch) up in the arm64 tree. It's a standalone tidy
>> up and means one fewer dependency next time round.

Agreed!

>
> Ok, I've picked this one up. Please re-post the rest of the series after
> the merge window.

Thanks for merging the patch. I'll re-post the series after the merge
window.

>
> Will
> _______________________________________________
> kvmarm mailing list
> kvmarm@xxxxxxxxxxxxxxxxxxxxx
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm