Re: [PATCH v2 01/14] irqchip: i8259: Add domain before mapping parent irq

From: Thomas Gleixner
Date: Fri Sep 30 2016 - 14:44:20 EST


On Fri, 30 Sep 2016, Paul Burton wrote:

> On Monday, 19 September 2016 22:21:18 BST Paul Burton wrote:
> > Mapping the parent IRQ will use a virq number which may conflict with
> > the hardcoded I8259A_IRQ_BASE..I8259A_IRQ_BASE+15 range that the i8259
> > driver expects to be free. If this occurs then we'll hit errors when
> > adding the i8259 IRQ domain, since one of its virq numbers will already
> > be in use.
> >
> > Avoid this by adding the i8259 domain before mapping the parent IRQ,
> > such that the i8259 virq numbers become used before the parent interrupt
> > controller gets a chance to use any of them.
>
> Hello,
>
> Any chance of getting reviews/acks on this & the following 2 patches in the
> series so Ralf can take them through the MIPS tree? The lack of these (well,
> patches 1 & 2 anyway) blocks applying many of the Malta patches later in the
> series.

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>