Re: [PATCH v3 7/7] i2c: bcm2835: Add support for dynamic clock

From: Eric Anholt
Date: Wed Sep 28 2016 - 17:24:55 EST


Noralf TrÃnnes <noralf@xxxxxxxxxxx> writes:

> Support a dynamic clock by reading the frequency and setting the
> divisor in the transfer function instead of during probe.

Is this fixing some particular case you could note in the commit
message? As is, it makes me think that we should be using a notifier
for when the parent clock (that's the one I assume you're talking about
being dynamic) changes. But maybe you're working around a variable VPU
clock being set by the firmware, because we don't have a notifier for
it?

I'm a bit worried because I think this is going to be pretty expensive
to be doing per transfer.

Attachment: signature.asc
Description: PGP signature