Re: [PATCH 1/3] megaraid_sas: mark symbols static where possible

From: Martin K. Petersen
Date: Mon Sep 26 2016 - 21:19:30 EST


>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@xxxxxxxxxx> writes:

Baoyou> We get a few warnings when building kernel with W=1:
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:94:5: warning: no
Baoyou> previous prototype for 'mega_mod64' [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:112:5: warning: no
Baoyou> previous prototype for 'mega_div64_32' [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:177:6: warning: no
Baoyou> previous prototype for 'MR_PopulateDrvRaidMap'
Baoyou> [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:315:5: warning: no
Baoyou> previous prototype for 'MR_GetSpanBlock' [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:451:5: warning: no
Baoyou> previous prototype for 'mr_spanset_get_span_block'
Baoyou> [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:692:4: warning: no
Baoyou> previous prototype for 'get_arm' [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:815:4: warning: no
Baoyou> previous prototype for 'MR_GetPhyParams' [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fp.c:1293:4: warning: no
Baoyou> previous prototype for 'megasas_get_best_arm_pd'
Baoyou> [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:106:1: warning: no
Baoyou> previous prototype for 'megasas_enable_intr_fusion'
Baoyou> [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:127:1: warning: no
Baoyou> previous prototype for 'megasas_disable_intr_fusion'
Baoyou> [-Wmissing-prototypes] ....

Does not apply. Please make sure your patches are against my for-next
branch.

--
Martin K. Petersen Oracle Linux Engineering