Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

From: Jan Stancek
Date: Mon Sep 26 2016 - 13:51:05 EST





----- Original Message -----
> From: "Marcelo Cerri" <marcelo.cerri@xxxxxxxxxxxxx>
> To: "Jan Stancek" <jstancek@xxxxxxxxxx>
> Cc: "rui y wang" <rui.y.wang@xxxxxxxxx>, herbert@xxxxxxxxxxxxxxxxxxx, mhcerri@xxxxxxxxxxxxxxxxxx,
> leosilva@xxxxxxxxxxxxxxxxxx, pfsmorigo@xxxxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx,
> linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Sent: Monday, 26 September, 2016 4:15:10 PM
> Subject: Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7
>
> Hi Jan,
>
> Just out of curiosity, have you tried to use "76" on both values to
> check if the problem still happens?

I did, I haven't seen any panics with such patch:

@@ -211,7 +212,7 @@ struct shash_alg p8_ghash_alg = {
.update = p8_ghash_update,
.final = p8_ghash_final,
.setkey = p8_ghash_setkey,
- .descsize = sizeof(struct p8_ghash_desc_ctx),
+ .descsize = sizeof(struct p8_ghash_desc_ctx) + 20,
.base = {
.cra_name = "ghash",
.cra_driver_name = "p8_ghash",