Re: [PATCH] clk: versatile: add missing header dependencies

From: Arnd Bergmann
Date: Sat Sep 24 2016 - 05:09:42 EST


On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in
> include/linux/platform_data/clk-realview.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
>

I think I commented on this one already: the only caller of the
function is getting removed in v4.9, so we should remove the
definition of the function subsequently in the next release.

We could in theory try to remove this at the same time, but
the effort to synchronize the git trees is not worth the benefit.

Arnd