Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

From: Greg Kroah-Hartman
Date: Tue Sep 20 2016 - 07:18:14 EST


On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> Being over zealous in removing unused EXPORT_SYMBOLs two functions
> lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> was done when porting to the upstream client.
>
> Signed-off-by: James Simmons <uja.ornl@xxxxxxxxx>
> Reviewed-on: http://review.whamcloud.com/14545
> Reviewed-on: http://review.whamcloud.com/15159
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6486
> Reviewed-by: Dmitry Eremin <dmitry.eremin@xxxxxxxxx>
> Reviewed-by: Bob Glossman <bob.glossman@xxxxxxxxx>
> Reviewed-by: John L. Hammond <john.hammond@xxxxxxxxx>
> Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> Signed-off-by: James Simmons <jsimmons@xxxxxxxxxxxxx>
> ---
> .../staging/lustre/lustre/ptlrpc/pack_generic.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> index 1349bf6..8717685 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> @@ -1861,6 +1861,7 @@ void lustre_swab_lmv_mds_md(union lmv_mds_md *lmm)
> break;
> }
> }
> +EXPORT_SYMBOL(lustre_swab_lmv_mds_md);

I don't see anyone else using this symbol, in fact, it could now be
marked static. So why export it?

> void lustre_swab_lmv_user_md(struct lmv_user_md *lum)
> {
> @@ -1914,6 +1915,7 @@ void lustre_swab_lov_mds_md(struct lov_mds_md *lmm)
> __swab16s(&lmm->lmm_stripe_count);
> __swab16s(&lmm->lmm_layout_gen);
> }
> +EXPORT_SYMBOL(lustre_swab_lov_mds_md);

This is used by other files (it's listed twice in lustre_idl.h...), so
it might need to be exported, but why am I not seeing a build error
without this change?

confused,

greg k-h