Re: [PATCH 5/8] gpio: ath79: fix implicit assumption module.h is present

From: Linus Walleij
Date: Thu Sep 15 2016 - 08:02:16 EST


On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:

> The Kconfig for this file is:
>
> drivers/gpio/Kconfig:config GPIO_ATH79
> drivers/gpio/Kconfig: tristate "Atheros AR71XX/AR724X/AR913X GPIO support"
>
> ...but however it does not include module.h -- it in turn gets it from
> another header (gpio/driver.h) and we'd like to replace that with a
> forward delcaration of "struct module;" but if we do, this file will
> fail to compile.
>
> So we fix this first to avoid putting build failures into the bisect
> commit history.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij