Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine

From: Bjorn Helgaas
Date: Wed Sep 14 2016 - 15:26:32 EST


On Wed, Sep 14, 2016 at 11:41:17AM +0300, Mika Westerberg wrote:
> On Mon, Sep 12, 2016 at 04:08:47PM -0500, Bjorn Helgaas wrote:
> > This is mostly Mayurkumar's work from [1] and [2]. I split [2] into two
> > patches and reworked it to keep the enclosing loop around the pciehp ISR.
> >
> > The patches I added are trivial ones to clarify variable names, make dmesg
> > messages consistent, and remove useless code.
> >
> > [1] 1471554479-42083-1-git-send-email-mayurkumar.patel@xxxxxxxxx
> > [2] 92EBB4272BF81E4089A7126EC1E7B28466598F35@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> >
> > ---
> >
> > Bjorn Helgaas (5):
> > PCI: pciehp: Rename pcie_isr() locals for clarity
> > PCI: pciehp: Return IRQ_NONE when we can't read interrupt status
> > PCI: pciehp: Remove unnecessary guard
> > PCI: pciehp: Clean up dmesg "Slot(%s)" messages
> > PCI: pciehp: Remove useless pciehp_get_latch_status() calls
> >
> > Mayurkumar Patel (3):
> > PCI: pciehp: Process all hotplug events before looking for new ones
> > PCI: pciehp: Don't re-read Slot Status when queuing hotplug event
> > PCI: pciehp: Don't re-read Slot Status when handling surprise event
> >
> >
> > drivers/pci/hotplug/pciehp_ctrl.c | 83 ++++++++++++---------------------
> > drivers/pci/hotplug/pciehp_hpc.c | 94 ++++++++++++++++++++-----------------
> > 2 files changed, 82 insertions(+), 95 deletions(-)
>
> I don't have any machines with native PCIe hotplug support enabled but
> regardless the series looks good to me,
>
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Thanks a lot for taking the time to review it! I added your Reviewed-by.