Re: [PATCH] pty: make ptmx file ops read-only after init

From: One Thousand Gnomes
Date: Wed Sep 14 2016 - 10:04:50 EST


On Wed, 14 Sep 2016 09:59:42 +0200
Jiri Slaby <jslaby@xxxxxxx> wrote:

> On 09/09/2016, 12:35 AM, Kees Cook wrote:
> > The ptmx_fops structure is only changed during init, so mark it as such.
>
> Right, but I am missing what is the benefit? You would have to elaborate
> here...

The pages end up marked read only even to the kernel (and in future could
even be marked read only forever when in kvm if we get suitable virtual
machine extensions). That makes it much harder to patch those vectors
when making security attacks.