Re: [PATCH v6] genirq: Machine-parsable version of /proc/interrupts

From: Thomas Gleixner
Date: Wed Sep 14 2016 - 09:39:28 EST


On Tue, 13 Sep 2016, Craig Gallek wrote:
> +What: /sys/kernel/irq/<irq>/name
> +Date: September 2016
> +KernelVersion: 4.9
> +Contact: Craig Gallek <kraig@xxxxxxxxxx>
> +Description: Human-readable flow handler name as defined by the device
> + driver.

That's ambigous. device driver reads like a the driver of the device which
uses this irq. I fixed that up.

> static void free_desc(unsigned int irq)
> {
> struct irq_desc *desc = irq_to_desc(irq);
>
> unregister_irq_proc(irq, desc);
> + kobject_del(&desc->kobj);

You forgot to move this under the sparse lock protection as well. There is
the same race against a concurrent initcall.

Thanks,

tglx