Re: [PATCH] clk: versatile: add missing header dependencies

From: Linus Walleij
Date: Wed Sep 14 2016 - 05:04:40 EST


On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
>>
>> In fact, this function is declared in clk-realview.h,
>> so this patch add missing header dependencies.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
>>
>
> Please leave this one for now. We are in the process of removing the
> last caller of this function, and should just remove the header file
> and the function definition in the next release.

+1 on this, leave it. I can clean it up for v4.10 or even
for an -rc if you want it real neat in v4.9.

Yours,
Linus Walleij