Re: [PATCH net-next 2/2] net: deprecate eth_change_mtu, remove usage

From: kbuild test robot
Date: Tue Sep 13 2016 - 17:59:39 EST


Hi Jarod,

[auto build test ERROR on net-next/master]

url: https://github.com/0day-ci/linux/commits/Jarod-Wilson/net-centralize-net_device-min-max-MTU-checking/20160913-042130
config: mips-xway_defconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips

All error/warnings (new ones prefixed by >>):

drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_change_mtu':
>> drivers/net/ethernet/lantiq_etop.c:524:7: error: 'ret' undeclared (first use in this function)
if (!ret) {
^
drivers/net/ethernet/lantiq_etop.c:524:7: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/lantiq_etop.c:534:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^

vim +/ret +524 drivers/net/ethernet/lantiq_etop.c

504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 518
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 519 static int
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 520 ltq_etop_change_mtu(struct net_device *dev, int new_mtu)
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 521 {
707d312a drivers/net/ethernet/lantiq_etop.c Jarod Wilson 2016-09-12 522 dev->mtu = new_mtu;
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 523
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 @524 if (!ret) {
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 525 struct ltq_etop_priv *priv = netdev_priv(dev);
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 526 unsigned long flags;
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 527
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 528 spin_lock_irqsave(&priv->lock, flags);
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 529 ltq_etop_w32((ETOP_PLEN_UNDER << 16) | new_mtu,
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 530 LTQ_ETOP_IGPLEN);
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 531 spin_unlock_irqrestore(&priv->lock, flags);
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 532 }
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 533 return ret;
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 @534 }
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 535
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 536 static int
504d4721 drivers/net/lantiq_etop.c John Crispin 2011-05-06 537 ltq_etop_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)

:::::: The code at line 524 was first introduced by commit
:::::: 504d4721ee8e432af4b5f196a08af38bc4dac5fe MIPS: Lantiq: Add ethernet driver

:::::: TO: John Crispin <blogic@xxxxxxxxxxx>
:::::: CC: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data