Re: [PATCH] drivers: net: phy: xgene: Fix 'remove' function

From: David Miller
Date: Tue Sep 13 2016 - 12:06:52 EST


From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Sun, 11 Sep 2016 21:43:34 +0200

> If 'IS_ERR(pdata->clk)' is true, then 'clk_disable_unprepare(pdata->clk)'
> will do nothing.
>
> It is likely that 'if (!IS_ERR(pdata->clk))' was expected here.
> In fact, the test can even be removed because 'clk_disable_unprepare'
> already handles such cases.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Applied.