Re: [RFC V3 PATCH 03/26] net/netpolicy: get device queue irq information

From: Alexander Duyck
Date: Tue Sep 13 2016 - 09:14:21 EST


On Tue, Sep 13, 2016 at 5:23 AM, Liang, Kan <kan.liang@xxxxxxxxx> wrote:
>>
>> Hello.
>>
>> On 09/12/2016 05:55 PM, kan.liang@xxxxxxxxx wrote:
>>
>> > From: Kan Liang <kan.liang@xxxxxxxxx>
>> >
>> > Net policy needs to know device information. Currently, it's enough to
>> > only get irq information of rx and tx queues.
>> >
>> > This patch introduces ndo ops to do so, not ethtool ops.
>> > Because there are already several ways to get irq information in
>> > userspace. It's not necessory to extend the ethtool.
>>
>> Necessary.
>
> OK. I will extend the ethtool in next version.
>
> Thanks,
> Kan

Kan, I don't think Sergei was saying you have to extend the ethtool.
Your spelling of necessary was incorrect in your patch description.

Sergei, please feel free to tell me I am wrong if my assumption on
that is incorrect.

- Alex