Re: [PATCH] tracing/hwlat: select TRACER_MAX_TRACE

From: Steven Rostedt
Date: Mon Sep 12 2016 - 10:03:20 EST


On Wed, 7 Sep 2016 18:08:31 +0200
Arnd Bergmann <arnd@xxxxxxxx> wrote:

> hwlat_trace cannot work without CONFIG_TRACER_MAX_TRACE:
>
> kernel/trace/trace_hwlat.c: In function 'get_sample':
> kernel/trace/trace_hwlat.c:258:18: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'?
> if (sample > tr->max_latency)
> ^~
> kernel/trace/trace_hwlat.c:259:6: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'?
> tr->max_latency = sample;
> ^~
> kernel/trace/trace_hwlat.c: In function 'hwlat_tracer_init':
> kernel/trace/trace_hwlat.c:583:4: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'?
> tr->max_latency = 0;
>
> We also have to enable CONFIG_TRACER_SNAPSHOT, which in turn
> is a dependency of CONFIG_TRACER_MAX_TRACE.

Hi Arnd,

Thanks.

Randy Dunlap already reported this, and it's been fixed. I just
finished testing and it will be uploaded today. The real fix was posted
in the thread here:

http://lkml.kernel.org/r/d6c3b7eb-ba95-1ffa-0453-464e1e24262a@xxxxxxxxxxxxx

-- Steve