RE: [PATCH] staging/fsl-mc: use consistent integer types

From: Stuart Yoder
Date: Fri Sep 09 2016 - 23:36:13 EST




> -----Original Message-----
> From: Thomas WeiÃschuh [mailto:linux@xxxxxxxxxxxxxx]
> Sent: Wednesday, September 07, 2016 1:21 PM
> To: J. German Rivera <German.Rivera@xxxxxxxxxxxxx>; Stuart Yoder <stuart.yoder@xxxxxxx>; Greg Kroah-
> Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Thomas WeiÃschuh <linux@xxxxxxxxxxxxxx>
> Subject: [PATCH] staging/fsl-mc: use consistent integer types
>
> Signed-off-by: Thomas WeiÃschuh <linux@xxxxxxxxxxxxxx>
> ---
> drivers/staging/fsl-mc/include/mc-private.h | 4 ++--
> drivers/staging/fsl-mc/include/mc.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fsl-mc/include/mc-private.h b/drivers/staging/fsl-mc/include/mc-private.h
> index cab1ae9..f95ee74 100644
> --- a/drivers/staging/fsl-mc/include/mc-private.h
> +++ b/drivers/staging/fsl-mc/include/mc-private.h
> @@ -79,8 +79,8 @@ struct fsl_mc_addr_translation_range {
> */
> struct fsl_mc_resource_pool {
> enum fsl_mc_pool_type type;
> - int16_t max_count;
> - int16_t free_count;
> + i16 max_count;
> + i16 free_count;

What is i16? ...not a valid type as far as I can see. Did you compile this?

The codebase you are based on has changed. There is no longer a file
called mc-private.h. Latest should be in Greg's staging-next branch.

Stuart