Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree.

From: Scott Branden
Date: Fri Sep 09 2016 - 12:37:39 EST


Hi Stefan,

On 16-09-08 11:58 PM, Stefan Wahren wrote:
Hi Scott,

Am 08.09.2016 um 21:50 schrieb Scott Branden:
Hi Gerd/Eric

On 16-09-08 12:44 AM, Gerd Hoffmann wrote:
On Mi, 2016-09-07 at 20:13 +0200, Stefan Wahren wrote:
Gerd Hoffmann <kraxel@xxxxxxxxxx> hat am 7. September 2016 um 12:31
geschrieben:


From: Eric Anholt <eric@xxxxxxxxxx>

This will be used for having EMMC (sdhci-bcm2835.c) drive the
wireless.

sdhci-bcm2835.c has been replaced by sdhci-iproc.c

Ah, right, I'll update the commit msg for v2.

Should we entirely remove sdhci-bcm2835.c to reduce confusion going
forward?

did i missed something?
No - looks like I did. Everything is cleaned up in latest.

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=46cd175c9788e39a1c57698ab58f34844d216428

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7eb16493ecaa41ceeb448717ee2c59690cd9047f



How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h?

Already there (or do you mean something other than '#define
BCM2835_FSEL_*' ?)

cheers,
Gerd


Thanks,
Scott