Re: Regulator probe

From: Mark Brown
Date: Fri Sep 09 2016 - 11:30:11 EST


On Fri, Sep 09, 2016 at 03:55:27PM +0300, Andy Shevchenko wrote:
> On Fri, 2016-09-09 at 13:17 +0100, Mark Brown wrote:

> > What do you mean?  Of course we should handle probe deferral if we
> > fail to get a resource like a GPIO.  Are you trying to say that this
> > doesn't work for you?

> No, it doesn't.

> Fixed regulator probe is deferred:

> reg-fixed-voltage reg-fixed-voltage.0.auto: Failed to register
> regulator: -517

So the regulator probe *does* get deferred as expected...

> But:
> sdhci-pci 0000:00:01.3: No vmmc regulator found

> Code in sdhci driver is:
>         ret = mmc_regulator_get_supply(mmc);
>         if (ret == -EPROBE_DEFER)
>                 return ret;
>
> mmc_regulator_get_supply():
> ...
>         mmc->supply.vmmc = devm_regulator_get_optional(dev, "vmmc");
>         mmc->supply.vqmmc = devm_regulator_get_optional(dev, "vqmmc");

...and then we correctly report that the optional supply that isn't
mapped (as far as I remember) isn't there.

Attachment: signature.asc
Description: PGP signature