Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent

From: Bartosz Golaszewski
Date: Thu Sep 08 2016 - 10:16:25 EST


2016-09-08 14:29 GMT+02:00 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
> On Thu, 2016-09-08 at 15:27 +0300, Andy Shevchenko wrote:
>> On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote:
>> >
>> > The register offset defines for the pca953x and pca957x expander
>> > families should have the same names to better reflect their similar
>> > purposes.
>>
>
> And one more question. If it is done in datasheet as is used currently
> in the driver I would leave it to be aligned with official
> documentation.
>

Right, the current names seem to come from the datasheet register
table. I'll drop this patch in v6.

Thanks,
Bartosz