Re: [PATCH] irda: Fix likely typo in output format string

From: Oleg Drokin
Date: Wed Aug 31 2016 - 17:37:25 EST



On Aug 31, 2016, at 5:31 PM, David Miller wrote:

> From: Oleg Drokin <green@xxxxxxxxxxxxxx>
> Date: Fri, 26 Aug 2016 23:14:06 -0400
>
>> %ul would print an unsigned with a letter l at the end which does
>> not seem to be desired here, on the other hand the value being printed
>> is u32 so just drop the l instead of converting to %lu
>>
>> Signed-off-by: Oleg Drokin <green@xxxxxxxxxxxxxx>
>
> %u is for unsigned values, and these are "s32" thus signed.

Hm, you are right.
I could swear I saw them as unsigned when I looked at it.

Anyway can they really be negative? they are seconds and usec,
should I change them to u32 too?