Re: [PATCH v2 12/26] MIPS: CPC: Provide a default mips_cpc_default_phys_base

[Sergei Shtylyov]

Hello.

On 8/30/2016 8:29 PM, Paul Burton wrote:

> Provide a weak default implementation of mips_cpc_default_phys_base
> which reads the base address of the CPC from the device tree if
> possible, and failing that returns the existing physical address of the
> CPC as read from CPC base address GCR. This allows for platforms to make
> use of the CPC without requiring platform code.
>
> Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
> ---
>
> Changes in v2: None
>
>  arch/mips/kernel/mips-cpc.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
> index 566b8d2..b188787 100644
> --- a/arch/mips/kernel/mips-cpc.c
> +++ b/arch/mips/kernel/mips-cpc.c
[...]
> @@ -21,6 +23,22 @@ static DEFINE_PER_CPU_ALIGNED(spinlock_t, cpc_core_lock);
>
>  static DEFINE_PER_CPU_ALIGNED(unsigned long, cpc_core_lock_flags);
>
> +__weak phys_addr_t mips_cpc_default_phys_base(void)

   I think it would look better as:

phys_addr_t __weak mips_cpc_default_phys_base(void)

   The other weak function you touch further in the patchset looks this way...

[...]

MBR, Sergei