Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

[Archit Taneja]

Hi,

On 08/29/2016 03:00 PM, Jose Abreu wrote:
> Colorspace and scan information values were being written in wrong
> offsets. This patch corrects this and writes the values at the
> offsets specified in the databook.

queued to drm-misc after cleaning up some checkpatch
errors.

Thanks,
Archit

> Signed-off-by: Jose Abreu <joabreu@xxxxxxxxxxxx>
> Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> Cc: Carlos Palminha <palminha@xxxxxxxxxxxx>
> Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>   drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index 77ab473..cdf39aa 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -940,10 +940,11 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
>   	 */
>
>   	/*
> -	 * AVI data byte 1 differences: Colorspace in bits 4,5 rather than 5,6,
> -	 * active aspect present in bit 6 rather than 4.
> +	 * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6,
> +	 * scan info in bits 4,5 rather than 0,1 and active aspect present in
> +	 * bit 6 rather than 4.
>   	 */
> -	val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3);
> +	val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3);
>   	if (frame.active_aspect & 15)
>   		val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT;
>   	if (frame.top_bar || frame.bottom_bar)

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project