Re: [PATCH] rtc: changed raw spi calls to register map calls

[Alexandre Belloni]

Hi,

Please fix the subject, this patch is ds1347 specific.

On 31/08/2016 at 01:28:33 +0530, RAGHAVENDRA GANIGA wrote :
> From 2ec82b6c9b99647e31d26c4c828dc7c51af8a633 Mon Sep 17 00:00:00 2001
> From: Raghavendra Ganiga <ravi23ganiga@xxxxxxxxx>
> Date: Wed, 31 Aug 2016 01:13:30 +0530
> Subject: [PATCH] rtc: changed raw spi calls to register map calls
> 
> This patch changes calls of spi read write calls to register map
> read and write calls
> 

Can you explain why you need that change? I'm not sure what you gain
from it (it makes the driver and the kernel bigger).

>  	/* year in linux is from 1900 i.e in range of 100
> -	in rtc it is from 00 to 99 */
> +	 * in rtc it is from 00 to 99
> +	 */

Unrelated change.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com