Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

[Steven Rostedt]

On Tue, 30 Aug 2016 16:37:28 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> On 08/29, Steven Rostedt wrote:
> >
> > On Mon, 29 Aug 2016 18:58:13 -0400
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >  
> > > On Thu, 25 Aug 2016 18:21:09 +0300
> > > Dmitry Safonov <dsafonov@xxxxxxxxxxxxx> wrote:
> > >  
> > > > It's useless. Before:
> > > >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > > >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > > >   -bash: echo: write error: No such file or directory
> > > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > > >   -bash: echo: write error: Invalid argument
> > > > 
> > > > After:
> > > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > > >   -bash: echo: write error: No such file or directory
> > > > 
> > > > Signed-off-by: Dmitry Safonov <dsafonov@xxxxxxxxxxxxx>    
> > > 
> > > Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>  
> >
> > Actually, this patch seems agnostic to the series. I'll just pull it in
> > now.  
> 
> Yes, agreed, this isdigit() is pointless, thanks.

Should I put you down as an Acked-by?

-- Steve