Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints

From: Steven Rostedt
Date: Tue Aug 30 2016 - 17:06:35 EST


On Tue, 30 Aug 2016 17:02:03 +0200
Daniel Wagner <daniel.wagner@xxxxxxxxxxxx> wrote:

> On 08/30/2016 04:20 PM, Daniel Wagner wrote:
> > Just setting the size of the type is not enough. The hist_field_*
> > getter function want to know the offset too:
>
> With this hack here it should work. The COMM generic field is handled via
> the tracing_map_ops. We could do it also there but than we need to
> a condition in the trace_map_ops if it is COMM or CPU.
> This shortcut here avoids it:
>

I think the tracing_map_ops is the proper fix. I'd like to keep comm
and cpu identical, as they are both basically "meta fields".

-- Steve