Re: [PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

From: Robert Jarzmik
Date: Tue Aug 30 2016 - 11:57:27 EST


Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes:

> Hi Robert,
>
> On Mon, 29 Aug 2016, Robert Jarzmik wrote:
>
>> Remove the soc_camera adherence. Mostly the change removes the power
>> manipulation provided by soc_camera, and instead :
>> - powers on the sensor when the s_power control is activated
>> - powers on the sensor in initial probe
>> - enables and disables the MCLK provided to it in power on/off
>
> Your patch also drops support for inverters on synchronisation and clock
> lines, I guess, your board doesn't use any. I assume, if any board ever
> needs such inverters, support for them can be added in the future.
Ah yeah, that would deserve a notice in the commit message.

It's a bit a pity to respin the whole serie for it, but you've got a fair
point. Maybe Hans would agree to apply 4/13 to 13/13 (if there is no comment
remaining), and let me respin the 3 patches around mtm9111.

> Also, as I mentioned in my reply to your other patch, maybe good to join this
> with #3. Otherwise and with that in mind
I'd like to keep the move separate from the remaining part. And yes, I should
have used the "-M" option ... I added it to my submission script so that I don't
forget it again :)

Thanks for the Ack, and cheers.

--
Robert