Re: [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller

From: Thomas Petazzoni
Date: Tue Aug 30 2016 - 10:15:42 EST


Hello,

On Tue, 23 Aug 2016 08:26:49 +0200, Marcin Wojtas wrote:
> Original commit, which added support for Armada CP110 system controller
> used global variables for storing all clock information. It worked
> fine for Armada 7k SoC, with single CP110 block. After dual-CP110 Armada 8k
> was introduced, the data got overwritten and corrupted.
>
> This patch fixes the issue by allocating resources dynamically in the
> driver probe and storing it as platform drvdata.
>
> Fixes: d3da3eaef7f4 ("clk: mvebu: new driver for Armada CP110 system ...")

Adding:

CC: <stable@xxxxxxxxxxxxxxx>

here would be useful.

>
> Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx>

Other than that:

Tested-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
(on Armada 8K hardware)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>

Thanks a lot for fixing the crap that I initially wrote :-/

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com