Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup

From: Sebastian Reichel
Date: Sun Aug 28 2016 - 20:37:24 EST


Hi,

On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote:
> This requests the status GPIO with initial input setup. it is required
> to read the GPIO status at probe time and thus correctly avoid sending
> i2c messages when AC is not plugged.
>
> When requesting the GPIO without initial input setup, it always reads 0
> which causes probe to fail as it assumes the charger is connected, sends
> i2c messages and fails.

Please convert the driver to devm_gpiod_get instead.

-- Sebastian

Attachment: signature.asc
Description: PGP signature