Re: [PATCH] fix:memory:of_memory:add missing header dependencies

From: Greg KH
Date: Sat Aug 27 2016 - 13:55:19 EST


On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:

Why would you do that?

> drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes]
> drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes]
>
> In fact, these functions are declared in drivers/memory/of_memory.h
> so this patch add missing header dependencies.

Why am I not seeing this warning on a "normal" build? If there's no
prototype of a function, that seems odd... What about sparse, does that
give you the same error here?

thanks,

greg k-h