Re: [PATCH] fix:iio:common:st_sensors:st_sensors_trigger:mark symbols static where possible

From: Linus Walleij
Date: Sat Aug 27 2016 - 04:45:10 EST


On Sat, Aug 27, 2016 at 8:26 AM, Baoyou Xie <baoyou.xie@xxxxxxxxxx> wrote:

> We get 2 warnings when biuld kernel with W=1:
> drivers/iio/common/st_sensors/st_sensors_trigger.c:69:13: warning: no previous prototype
> for 'st_sensors_irq_handler' [-Wmissing-prototypes]
> drivers/iio/common/st_sensors/st_sensors_trigger.c:85:13: warning: no previous prototype
> for 'st_sensors_irq_thread' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij