Re: [GIT PULL] Block fixes for 4.8-rc4

[Jens Axboe]

On 08/26/2016 07:55 PM, Linus Torvalds wrote:
> On Fri, Aug 26, 2016 at 8:16 AM, Jens Axboe <axboe@xxxxxx> wrote:
> > Hi Linus,
> >
> > - Revert two previous floppy changes, since they caused a user visibile
> >   regression. A better fix is in the works.
>
> Those reverts have no sign-off, and no explanation for them.
>
> No, a revert may not have any copyright value, but the sign-offs have
> been our main way to also see who actually did stuff and what the
> chain was. All the usual "who caused this" background for reverts.
>
> What was it that went wrong? Nobody knows. Not from the logs, at least.

You are right, those reverts should have the reasoning included.

> I pulled it, but just FYI: reverts need explanations too. They need to
> explain why they happened and what went wrong.

Thanks.

--
Jens Axboe