Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null

From: David Miller
Date: Fri Aug 26 2016 - 14:45:50 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2016 07:51:10 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> ppe_cb->ppe_common_cb is being dereferenced before a null check is
> being made on it. If ppe_cb->ppe_common_cb is null then we end up
> with a null pointer dereference when assigning dsaf_dev. Fix this
> by moving the initialisation of dsaf_dev once we know
> ppe_cb->ppe_common_cb is OK to dereference.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.