Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1

[Xing Zheng]

Hi Shawn,

On 2016å08æ26æ 17:41, Shawn Lin wrote:
> On 2016/8/26 14:22, Xing Zheng wrote:
> > Dues to incorrect description in the TRM, the WDTs base address
> > should be fixed and swap them like this:
> > WDT0 - 0xff848000
> > WDT1 - 0xff840000
> >
> > And, it is right that only WDT0 can generate global software reset.
> > We will update the TRM to fix it.
> >
> > Signed-off-by: Xing Zheng <zhengxing@xxxxxxxxxxxxxx>
> > ---
> >
> > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
> > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index bc86e8c..f0f52c1 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -1002,9 +1002,9 @@
> > };
> > };
> >
> > - watchdog@ff840000 {
> > + watchdog@ff848000 {
>
> Just a nit, should we mark this explicitly as "watchdog0" ?
> I still need to look up for which wdt you are using.:)
Done.

Thanks.
> > compatible = "snps,dw-wdt";
> > - reg = <0x0 0xff840000 0x0 0x100>;
> > + reg = <0x0 0xff848000 0x0 0x100>;
> > clocks = <&cru PCLK_WDT>;
> > interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> > };


--
- Xing Zheng