Re: [PATCH v1 net-next 1/1] fs: gfs2: Check if the return value of rhashtable_walk_start is -EAGAIN

From: Feng Gao
Date: Fri Aug 26 2016 - 00:50:30 EST


On Tue, Aug 23, 2016 at 10:18 PM, <fgao@xxxxxxxxxx> wrote:
> From: Gao Feng <fgao@xxxxxxxxxx>
>
> When rhashtable_walk_start returns -EAGAIN, it means the resize event
> happened but the iterator still could be used. So it should not be
> treated as an error in gfs2_glock_seq_start.
>
> Signed-off-by: Gao Feng <fgao@xxxxxxxxxx>
> ---
> fs/gfs2/glock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 3a90b2b..732721b 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -1818,7 +1818,7 @@ static void *gfs2_glock_seq_start(struct seq_file *seq, loff_t *pos)
> n = (*pos - gi->last_pos);
>
> ret = rhashtable_walk_start(&gi->hti);
> - if (ret)
> + if (ret && ret != -EAGAIN)
> return NULL;
>
> do {
> --
> 1.9.1
>
>

Sorry, this patch should be generated based on linux-gfs2.git.
I will resubmit it, so this one is superseded.

Regards
Feng.