RE: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions

From: KY Srinivasan
Date: Thu Aug 25 2016 - 13:34:10 EST




> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@xxxxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Yauheni Kaliuta
> Sent: Wednesday, August 24, 2016 9:54 PM
> To: kys@xxxxxxxxxxxxxxxxxxxxxx
> Cc: olaf@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; jasowang@xxxxxxxxxx; Alex
> Ng (LIS) <alexng@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> apw@xxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> leann.ogasawara@xxxxxxxxxxxxx
> Subject: Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add
> regions
>
> Hi, kys!
>
> >>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys wrote:
>
> [...]
>
> > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
> > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
> > {
> > struct list_head *cur;
> > struct hv_hotadd_state *has;
> > + struct hv_hotadd_gap *gap;
> > unsigned long residual, new_inc;
>
> > if (list_empty(&dm_device.ha_region_list))
>
> One "return false;" left here.

It is fixed up later in the series and the series is bisectable.

K. Y