Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

From: Rusty Russell
Date: Thu Aug 25 2016 - 07:32:34 EST


Jiri Kosina <jikos@xxxxxxxxxx> writes:
> On Wed, 24 Aug 2016, Josh Poimboeuf wrote:
>
>> There's no reliable way to determine which module tainted the kernel
>> with CONFIG_LIVEPATCH. For example, /sys/module/<klp module>/taint
>> doesn't report it. Neither does the "mod -t" command in the crash tool.
>>
>> Make it crystal clear who the guilty party is by converting
>> CONFIG_LIVEPATCH to a module taint flag.
>>
>> This changes the behavior a bit: now the the flag gets set when the
>> module is loaded, rather than when it's enabled.
>>
>> Reviewed-by: Chunyu Hu <chuhu@xxxxxxxxxx>
>> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
>
> I like this change.
>
> Rusty, in case you're okay with it as well, could you please either
> provide your Ack so that I could take it through livepatching.git?
> Alternatively, if you prefer to merge this through your tree, please feel
> free to add

Happy to leave it to you :)

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Thanks,
Rusty.