Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option

From: Philipp Zabel
Date: Thu Aug 25 2016 - 03:23:22 EST


Am Mittwoch, den 24.08.2016, 10:26 -0500 schrieb Dinh Nguyen:
> Hi Philipp,
>
> just a minor nit:
>
> On 08/24/2016 08:28 AM, Philipp Zabel wrote:
> > Visible only if COMPILE_TEST is enabled, this allows to include the
> > driver in build tests.
> >
> > Cc: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > ---
> > drivers/reset/Kconfig | 6 ++++++
> > drivers/reset/Makefile | 2 +-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 6ac631e..354e281 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -49,6 +49,12 @@ config RESET_PISTACHIO
> > help
> > This enables the reset driver for ImgTec Pistachio SoCs.
> >
> > +config RESET_SOCFPGA
> > + bool "SoC FPGA Reset Driver" if COMPILE_TEST
>
> Prefer to be "SoCFPGA", no space in between.
>
[...]
>
> Otherwise,
>
> Acked-by: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>

Thank you, I'll fix this.

regards
Philipp