Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h

From: Bart Van Assche
Date: Tue Aug 23 2016 - 09:57:18 EST


On 08/22/16 11:32, Mikko Rapeli wrote:
> - * uint32_t (*get_region_size)(struct dm_dirty_log *log);
> + * __u32 (*get_region_size)(struct dm_dirty_log *log);

uint32_t is a type that is defined by ANSI C but __u32 not. So this
change looks wrong to me. Would it have been sufficient to add "#include
<linux/types.h>" and keep the uint32_t etc. type names?

Bart.