Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints

From: Mark Brown
Date: Tue Aug 23 2016 - 07:21:35 EST


On Tue, Aug 23, 2016 at 12:17:23PM +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 23, 2016 at 2:09 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > Sure, but the constraints also say that you can do 1.32V which the
> > system is not physically capable of delivering. That's not a good sign
> > for the constraints, it suggests that at least the capabilities of the
> > regulator have not been taken into consideration when setting up the
> > constraints.

> So to be clear, the constraints should be the intersection of the
> recommended operating parameters of the consumer and the regulator's
> output, with the voltage/current steps taken in to consideration.

The constraints are there to say what the *system* can deliver. That
includes the limitations of the consumers, the regulators and the
physical design of the board. Just as one shouldn't just throw in the
maximum voltage range that the regulator can deliver one also shouldn't
just use the maximum voltage range a consumer can support for similar
reasons.

Attachment: signature.asc
Description: PGP signature