Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

From: Felipe Ferreri Tonello
Date: Tue Aug 23 2016 - 06:20:49 EST


Hi,

On 22/08/16 08:45, Felipe Balbi wrote:
>
> Hi,
>
> John Youn <John.Youn@xxxxxxxxxxxx> writes:
>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote:
>>> Use gadget's framework allocation function instead of directly calling
>>> usb_ep_alloc_request().
>>>
>>> Signed-off-by: Felipe F. Tonello <eu@xxxxxxxxxxxxxxxxx>
>>> ---
>>> drivers/usb/gadget/function/f_hid.c | 6 +-----
>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
>>> index a010496e4e05..89d2e9a5a04f 100644
>>> --- a/drivers/usb/gadget/function/f_hid.c
>>> +++ b/drivers/usb/gadget/function/f_hid.c
>>> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
>>>
>>> /* preallocate request and buffer */
>>> status = -ENOMEM;
>>> - hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
>>> + hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>>> if (!hidg->req)
>>> goto fail;
>>>
>>> - hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
>>> - if (!hidg->req->buf)
>>> - goto fail;
>>> -
>>> /* set descriptor dynamic values */
>>> hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>>> hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
>>>
>>
>> Hi Felipe,
>>
>> This commit on your testing/next breaks compilation.
>>
>> ../drivers/usb/gadget/function/f_hid.c: In function âhidg_bindâ:
>> ../drivers/usb/gadget/function/f_hid.c:620:14: error: too few arguments to function âalloc_ep_reqâ
>> hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>> ^
>> In file included from ../drivers/usb/gadget/function/f_hid.c:24:0:
>> ../drivers/usb/gadget/u_f.h:63:21: note: declared here
>> struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);
>
> true that :-) Dropping from my queue.
>

Are you applying the previous patches? Specially that this is the last
patch in the series, how can it break with you if it doesn't break here?
What should I do then?

Thanks

--
Felipe

Attachment: 0x92698E6A.asc
Description: application/pgp-keys