Re: [PATCH 1/4] KVM-S390: Improve determination of sizes in kvm_s390_import_bp_data()

From: Cornelia Huck
Date: Mon Aug 22 2016 - 08:58:22 EST


On Thu, 18 Aug 2016 12:55:11 +0200
Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:

> This is _not_ premature optimization. (k)calloc tells the reader that
> it's safe not to initialize part of the array. kmalloc_array says the
> opposite. Using the right function adds important hints in the
> code---which unlike comments cannot get stale without also introducing
> visible bugs.

Ack. I'd accept a patch changing this to use kmalloc_array.