Re: [PATCH] pinctrl: palmas: fix a possible NULL dereference

From: Linus Walleij
Date: Mon Aug 22 2016 - 08:11:57 EST


On Tue, Aug 16, 2016 at 10:36 AM, LABBE Corentin
<clabbe.montjoie@xxxxxxxxx> wrote:

> of_match_device could return NULL, and so cause a NULL pointer
> dereference later at line 1009:
> pinctrl_data = match->data;
>
> For fixing this problem, we use of_device_get_match_data(), this will
> simplify the code a little by using a standard function for
> getting the match data.
>
> Reported-by: coverity (CID 1324136)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@xxxxxxxxx>

Patch applied.

Yours,
Linus Walleij