Re: [PATCH 11/11] cpufreq: intel_pstate: Use CPPC to get max performance

From: kbuild test robot
Date: Mon Aug 22 2016 - 08:00:19 EST


Hi Srinivas,

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/Srinivas-Pandruvada/Support-Intel-Turbo-Boost-Max-Technology-3-0/20160819-101955
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-h0-08210914 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers/acpi/cppc_acpi.c: In function 'cpc_read':
>> drivers/acpi/cppc_acpi.c:731:11: error: implicit declaration of function 'readq_relaxed' [-Werror=implicit-function-declaration]
*val = readq_relaxed(vaddr);
^~~~~~~~~~~~~
drivers/acpi/cppc_acpi.c: In function 'cpc_write':
>> drivers/acpi/cppc_acpi.c:764:4: error: implicit declaration of function 'writeq_relaxed' [-Werror=implicit-function-declaration]
writeq_relaxed(val, vaddr);
^~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/readq_relaxed +731 drivers/acpi/cppc_acpi.c

beee23ae Prakash, Prashanth 2016-02-17 725 *val = readw_relaxed(vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 726 break;
77e3d86f Prakash, Prashanth 2016-02-17 727 case 32:
beee23ae Prakash, Prashanth 2016-02-17 728 *val = readl_relaxed(vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 729 break;
77e3d86f Prakash, Prashanth 2016-02-17 730 case 64:
beee23ae Prakash, Prashanth 2016-02-17 @731 *val = readq_relaxed(vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 732 break;
77e3d86f Prakash, Prashanth 2016-02-17 733 default:
77e3d86f Prakash, Prashanth 2016-02-17 734 pr_debug("Error: Cannot read %u bit width from PCC\n",
77e3d86f Prakash, Prashanth 2016-02-17 735 reg->bit_width);
77e3d86f Prakash, Prashanth 2016-02-17 736 ret_val = -EFAULT;
77e3d86f Prakash, Prashanth 2016-02-17 737 }
c39ec8bd Srinivas Pandruvada 2016-08-18 738 } else if (reg->space_id == ACPI_ADR_SPACE_FIXED_HARDWARE) {
c39ec8bd Srinivas Pandruvada 2016-08-18 739 ret_val = cpc_read_ffh(cpunum, reg, val);
77e3d86f Prakash, Prashanth 2016-02-17 740 } else
77e3d86f Prakash, Prashanth 2016-02-17 741 ret_val = acpi_os_read_memory((acpi_physical_address)reg->address,
337aadff Ashwin Chaugule 2015-10-02 742 val, reg->bit_width);
77e3d86f Prakash, Prashanth 2016-02-17 743 return ret_val;
337aadff Ashwin Chaugule 2015-10-02 744 }
337aadff Ashwin Chaugule 2015-10-02 745
c39ec8bd Srinivas Pandruvada 2016-08-18 746 static int cpc_write(int cpunum, struct cpc_reg *reg, u64 val)
337aadff Ashwin Chaugule 2015-10-02 747 {
77e3d86f Prakash, Prashanth 2016-02-17 748 int ret_val = 0;
77e3d86f Prakash, Prashanth 2016-02-17 749
77e3d86f Prakash, Prashanth 2016-02-17 750 if (reg->space_id == ACPI_ADR_SPACE_PLATFORM_COMM) {
77e3d86f Prakash, Prashanth 2016-02-17 751 void __iomem *vaddr = GET_PCC_VADDR(reg->address);
337aadff Ashwin Chaugule 2015-10-02 752
77e3d86f Prakash, Prashanth 2016-02-17 753 switch (reg->bit_width) {
77e3d86f Prakash, Prashanth 2016-02-17 754 case 8:
beee23ae Prakash, Prashanth 2016-02-17 755 writeb_relaxed(val, vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 756 break;
77e3d86f Prakash, Prashanth 2016-02-17 757 case 16:
beee23ae Prakash, Prashanth 2016-02-17 758 writew_relaxed(val, vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 759 break;
77e3d86f Prakash, Prashanth 2016-02-17 760 case 32:
beee23ae Prakash, Prashanth 2016-02-17 761 writel_relaxed(val, vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 762 break;
77e3d86f Prakash, Prashanth 2016-02-17 763 case 64:
beee23ae Prakash, Prashanth 2016-02-17 @764 writeq_relaxed(val, vaddr);
77e3d86f Prakash, Prashanth 2016-02-17 765 break;
77e3d86f Prakash, Prashanth 2016-02-17 766 default:
77e3d86f Prakash, Prashanth 2016-02-17 767 pr_debug("Error: Cannot write %u bit width to PCC\n",

:::::: The code at line 731 was first introduced by commit
:::::: beee23aebc6650609ef1547f6d813fa5065f74aa ACPI / CPPC: replace writeX/readX to PCC with relaxed version

:::::: TO: Prakash, Prashanth <pprakash@xxxxxxxxxxxxxx>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data