Re: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

From: Greg Kroah-Hartman
Date: Sun Aug 21 2016 - 17:29:23 EST


On Tue, Aug 09, 2016 at 01:34:57AM -0400, Lidza Louina wrote:
> The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
> The code had an up() where a down() should've been. This patch fixes that.
>
> Signed-off-by: Lidza Louina <Lidza.Louina@xxxxxxxxxx>
> ---
>  drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> index 7748523..16f0b19 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> @@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
>   allow_signal(SIGTERM);
>  
>   pcmdpriv->cmdthd_running = true;
> - up(&pcmdpriv->terminate_cmdthread_sema);
> + down(&pcmdpriv->terminate_cmdthread_sema);
>  
>   RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
>  
> -- 
> 2.7.4

This path is corrupted somehow and doesn't apply at all :(

Can you see what went wrong with your email client and try again?

thanks,

greg k-h