RE: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

From: Marciniszyn, Mike
Date: Fri Aug 19 2016 - 11:30:31 EST


> Subject: [PATCH] IB/qib: Use memdup_user() rather than duplicating its
> diff --git a/drivers/infiniband/hw/qib/qib_fs.c

I would be even more aggressive at reducing lines of code.

For example do direct returns when ok to do:
if (pos != 0 || count != sizeof(struct qib_flash))
return -EINVAL;

tmp = memdup_user(buf, count);
if (IS_ERR(tmp))
return PTR_ERR(tmp);

The bail_tmp: label is then not needed.

Mike