Re: [PATCH V3 0/3] Add support for session ID user filtering

From: Paul Moore
Date: Fri Aug 19 2016 - 08:22:24 EST


On Fri, Aug 19, 2016 at 12:36 AM, Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
> On 2016-08-18 19:53, Paul Moore wrote:
>> These patches look fine to me; the only comment I have is that these
>> should probably be combined into a single patch to avoid
>> cherry-picking of individual pieces, e.g. skipping the feature bitmap
>> or AUDIT_SESSION_SET support. I can do that when I merge the patches,
>> no need to resend unless you really want to ...
>>
>> However, the bigger issue is coordination with the userspace patches.
>> I really don't like merging kernel patches until Steve OK's the
>> corresponding userspace patches.
>
> Well, some thought went in to making the two behave properly in the
> absence of an update of the other. This was the primary reason for the
> re-spin. That part of the process is working, since it was Steve's
> feedback that provoked the respin.

The issues isn't so much in making the different bits behave under
different circumstances - they need to do that period - the issue is
that I don't want to include new functionality in the kernel that
doesn't have a user (or one on the horizon).

--
paul moore
www.paul-moore.com