Re: [PATCH v2] libnvdimm: Fix nvdimm_probe error on NVDIMM-N

From: Johannes Thumshirn
Date: Fri Aug 19 2016 - 04:17:50 EST


On Tue, Aug 16, 2016 at 01:08:40PM -0600, Toshi Kani wrote:
> 'ndctl list --buses --dimms' does not list any NVDIMM-Ns since
> they are considered as idle. ndctl checks if any driver is
> attached to nmem device. nvdimm_probe() always fails in
> nvdimm_init_nsarea() since NVDIMM-Ns do not implement optinal
> ND_CMD_GET_CONFIG_DATA command.
>
> Change nvdimm_probe() to accept the case that the CONFIG_DATA
> command is not implemented for NVDIMM-Ns. The driver attaches
> without ndd, which keeps it no-op to the device.
>
> Reported-by: Brian Boylston <brian.boylston@xxxxxxx>
> Signed-off-by: Toshi Kani <toshi.kani@xxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>

Tested-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
Acked-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850